ST_MakeLine fails for export with pgsql2shp

[bporfidia]

making linestring with st_makeline from a table of points, fails the export with pgsql2shp and connection to qgis

postgis ver.

SELECT postgis_full_version() "POSTGIS="1.5.1" GEOS="3.2.0-CAPI-1.6.0" PROJ="Rel. 4.6.1, 21 August 2008" LIBXML="2.7.6" USE_STATS"

export error C:\Programmi\PostgreSQL\8.4\bin>pgsql2shp.exe -h xxx.xxx.xxx.xxx -u postgres -P postgres -r -b -f linee.shp geofisica public.nav

Initializing… Done (postgis major version: 1). Output shape: PolyLine Dumping: XRecordFetch: ERROR: geometry requires more points

[bporfidia]

table_made_by_makeline dump

[strk]

Culprit is ST_asEWKB() which complains in 1.5 but doesn't complain in 2.0. Normal dumps (done with pg_dump) won't complain as they'd be using canonical output.

I think we could change 1.5 to also not complain. Doing so would allow another 2.0 upgrade path (stepping by shapefiles)

[strk]

It strikes me that

 result = serialized_lwgeom_from_ewkt(&lwg_parser_result, str, PARSER_CHECK_ALL);

does _not_ fail when passed the single-point linestring HEXWKB, is that expected ?

[strk]

Fixed by r8443